nuttxpr commented on PR #14160: URL: https://github.com/apache/nuttx/pull/14160#issuecomment-2408442415
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR addresses an issue where 64-bit access to GIC registers causes data aborts when NEON is enabled. It modifies the code to split 64-bit access into two 32-bit accesses. However, the PR lacks details in the "Impact" and "Testing" sections to meet the NuttX requirements fully. Here's what's missing: **Impact:** * **Is new feature added? Is existing feature changed?** The PR fixes an existing feature (accessing GIC registers). This should be stated explicitly. * **Impact on hardware (will arch(s) / board(s) / driver(s) change)?** The PR specifically targets armv8-r/gicv3. This impact should be clearly mentioned. * While other impact categories might be N/A, it's better to state them explicitly for clarity. **Testing:** * **Build Host(s):** Specify the operating system, CPU architecture, and compiler used for building and testing the changes. * **Target(s):** Specify the architecture and board configuration used for testing. * **Testing logs before change:** Provide logs demonstrating the issue before applying the fix. * **Testing logs after change:** Provide logs showing the issue is resolved after applying the fix. "ci-check" isn't enough detail. **In summary, the PR is incomplete and requires more details in the "Impact" and "Testing" sections to meet the NuttX requirements.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
