nuttxpr commented on PR #14163: URL: https://github.com/apache/nuttx/pull/14163#issuecomment-2408446716
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX Requirements.** **Missing Information:** * **Summary:** * Lacks specifics on what "vsock framework preparation" entails. What functional code is changed? How does the change work? * **Impact:** * "No, new feature" is contradictory. Clarify if this is a new feature or not. * All other impact points simply state "NO" without providing details. The PR needs to explicitly address each impact area, even if it's to say "No impact" with a brief explanation. * **Testing:** * "CI" is insufficient. Provide: * Specific build host details (OS, CPU, compiler versions). * Specific target details (architecture, board, configuration). * Relevant testing logs before and after the change, demonstrating the issue and the fix. **Recommendations:** 1. **Expand the Summary:** Provide a clear and concise explanation of the change's purpose, the specific code affected, and the mechanics of the implementation. 2. **Address All Impact Points:** For each impact category, provide a detailed explanation or explicitly state "No impact" with a brief justification (e.g., "No impact on documentation as this change does not introduce new user-facing functionality"). 3. **Provide Thorough Testing Information:** List all build hosts and targets used for testing, including their specific configurations. Include relevant log snippets that showcase the problem before the change and the successful outcome after the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
