nuttxpr commented on PR #14164: URL: https://github.com/apache/nuttx/pull/14164#issuecomment-2408452628
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** Here's why: * **Summary:** * **Missing crucial information:** The summary needs to be far more detailed. Explain *why* the fix is necessary (what was the problem?), *what* specifically changed in the `sched_backtrace` function, and *how* the change addresses the original issue. * **Impact:** * **Incomplete:** Simply stating "sched_backtrace" doesn't provide enough context. Address *all* impact points (user impact, build impact, etc.) with "YES" or "NO". If "YES", provide a clear explanation. * **Testing:** * **Insufficient:** * Tagging a user to "give some testing info" is not acceptable. The PR submitter is responsible for providing comprehensive testing details. * Include specific details about your build host (OS, CPU, compiler) and target (architecture, board, configuration). * Provide actual testing logs from *before* and *after* the change to demonstrate the fix's effectiveness. **To improve this PR:** 1. **Expand the Summary:** Provide a thorough explanation of the problem, the solution, and how it works. 2. **Complete the Impact Assessment:** Address each impact point with "YES" or "NO". Provide explanations for all "YES" responses. 3. **Provide Detailed Testing Information:** Include specifics about your build host, target environment, and the actual testing logs showcasing the issue before the fix and the successful outcome after the fix. **Remember:** A well-structured and informative PR is crucial for maintainers to review and merge your changes effectively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
