nuttxpr commented on PR #2702: URL: https://github.com/apache/nuttx-apps/pull/2702#issuecomment-2408454916
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is lacking some details. Here's a breakdown and suggestions: **What's Missing in the Summary** * **Why:** The summary states WHAT is being changed ("make libuv use epoll", "make inotify test runnable"), but not WHY these changes are necessary. * Is there a bug being fixed? * Is this adding a new capability to NuttX? * Is it improving performance? * **How (more details):** The summary is very high-level. It would be helpful to elaborate on HOW these changes are implemented: * **libuv epoll:** What parts of the libuv code were modified to support epoll? Were any new files added? * **inotify test:** What prevented the inotify test from running previously? What changes were needed to make it functional? * **Issues/PRs:** The summary should explicitly link to any related NuttX issues or pull requests. **Impact Section: Needs More Detail** * **Stack Memory:** Quantify the impact. How much more stack memory is used? Is this a significant concern for resource-constrained devices? * **Other Impacts:** The PR focuses solely on stack memory. Consider these questions: * **Build:** Will any build system changes be needed (new configuration options, dependencies)? * **Hardware:** Does epoll have any specific hardware requirements or dependencies? * **Documentation:** Will documentation need to be updated to reflect these changes? * **Compatibility:** Could these changes potentially break existing applications or have compatibility implications? **Testing Section: Missing Context** * **Testing Environment:** Provide details about your testing setup: * Which NuttX version are you using? * What is your target hardware (or simulator)? * Which compiler and toolchain were used? * **Log Snippets:** The current logs are just test names. Include relevant snippets of the logs that demonstrate the changes in behavior before and after your modifications. Focus on: * **libuv epoll:** Show logs that confirm epoll is being used correctly. * **inotify test:** Show that the test, which previously failed, now passes. **In conclusion:** The PR needs more detail and context to meet NuttX requirements. Focus on explaining the "why" behind the changes, providing specifics about the implementation, quantifying the impact, and including relevant testing details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
