nuttxpr commented on PR #14175: URL: https://github.com/apache/nuttx/pull/14175#issuecomment-2408538486
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not fully meet the NuttX requirements.** Here's why and how to improve it: * **Summary:** While you list the changes, you don't explain *why* they are necessary. * **What was the specific bug?** Provide a brief description or link to a relevant issue. * **Why are the unused CMake options being removed?** Is it just cleanup, or does it have functional implications? * **What is `EXTRA_FLAGS` used for?** Explain the purpose and benefits of this new feature. * **Impact:** You need to be more specific in the "No Impact" sections. Just saying "No impact" is not sufficient. For example: * **Impact on user:** State *which* users are not impacted. Is it application developers, board config maintainers, etc.? * **Impact on build:** If there's truly no impact, state that the build process itself remains unchanged. * **Go through *each* impact category.** Even if nothing changes, explicitly stating "No impact, [reason]" demonstrates you've considered it. * **Testing:** * **"ubuntu sim" is too vague.** Specify the Ubuntu version and the simulator being used (e.g., QEMU). * **"CI build" is not informative enough.** Link to the specific CI run triggered by your PR. * **Provide actual testing logs (or snippets).** The template asks for "before" and "after" logs to demonstrate the problem and the fix. **In short, the PR description needs more details and context to be helpful for reviewers.** Clearly explain the problem, the solution, and provide concrete evidence that the changes work as intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
