nuttxpr commented on PR #14186: URL: https://github.com/apache/nuttx/pull/14186#issuecomment-2408562922
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This Pull Request (PR) **partially meets** the NuttX requirements. **What's Good:** * **Clear Summary:** The summary clearly outlines the change's purpose (renaming for consistency), the affected code area (sched/instrument), and how the change is implemented (renaming a file). **What Needs Improvement:** * **Impact:** The "Impact" section is entirely empty. You must address each impact category (user, build, hardware, documentation, security, compatibility) with a "NO" or a "YES" followed by a description if applicable. Even if the impact is "NO" for most, you need to explicitly state that. * **Testing:** * **Insufficient Detail:** Specify the build hosts and targets used for testing. Mention the operating systems, architectures, compilers, boards, and configurations. * **Missing Logs:** Provide actual testing logs from before and after the change. This demonstrates the change's effect and helps reviewers verify its correctness. **Example Impact and Testing Sections** ``` ## Impact * Is new feature added? Is existing feature changed? NO * Impact on user (will user need to adapt to change)? NO * Impact on build (will build process change)? NO (The build system will automatically adapt to the file rename) * Impact on hardware (will arch(s) / board(s) / driver(s) change)? NO * Impact on documentation (is update required / provided)? YES (Any documentation referencing stack_record.c will need to be updated to stack_monitor.c) * Impact on security (any sort of implications)? NO * Impact on compatibility (backward/forward/interoperability)? NO * Anything else to consider? NO ## Testing I confirm that changes are verified on local setup and works as intended: * Build Host(s): Ubuntu 20.04, x86_64, GCC 9.4.0 * Target(s): * Simulator (qemu-arm): sim:nsh * STM32F4 Discovery board: stm32f4discovery:nsh Testing logs before change: ``` (Logs showing the use of stack_record.c functionality) ``` Testing logs after change: ``` (Logs showing the same functionality working with stack_monitor.c) ``` ``` **By providing the missing information in the Impact and Testing sections, you will make your PR much stronger and easier for the NuttX maintainers to review.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
