nuttxpr commented on PR #14191: URL: https://github.com/apache/nuttx/pull/14191#issuecomment-2408568060
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to **partially meet** the NuttX requirements. Here's a breakdown: **Strengths:** * **Summary:** The summary clearly states the change (removing unused functions) and the affected area (sched/pthread). However, it would be beneficial to add: * **Why:** Briefly explain the reason for removing these functions (e.g., code cleanup, reducing binary size). * **Related issues:** If this change addresses an existing issue in NuttX, provide a link to it. * **Testing:** The PR provides sections for testing logs, which is good practice. **Areas for improvement:** * **Impact:** This section is entirely missing. You need to analyze and address each point: * **New/Changed features:** Are any features affected by this removal? * **Impact on users, builds, hardware, documentation, security, and compatibility:** Since it involves removing code, analyze potential impacts on each of these aspects. Even if the impact is "NO", state it explicitly. * **Other considerations:** Mention any other relevant aspects. * **Testing:** * **Provide actual testing logs:** The sections for testing logs are currently empty. Populate them with relevant logs from your testing before and after the change. * **Testing details:** Specify the build hosts and targets used for testing. Include operating systems, architectures, boards, and configurations. **Recommendation:** Before submitting, complete the "Impact" section and provide detailed information in the "Testing" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
