nuttxpr commented on PR #14188: URL: https://github.com/apache/nuttx/pull/14188#issuecomment-2408568751
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** meet the NuttX requirements. Here's why: * **Insufficient Summary:** * The summary lacks details. * What driver is being discussed? * What message is it waiting for? * How does the deadlock occur? * What is the exact mechanism used to cancel the work and release the netlock? * **Incomplete Impact Assessment:** * The impact section only mentions "igmp" which is not descriptive enough. * It needs to address all the listed points with YES/NO and explanations, such as: * **Is a new feature added?** * **Is an existing feature changed?** * **Impact on user?** * **Impact on build?** * **Impact on hardware?** * **Impact on documentation?** * **Impact on security?** * **Impact on compatibility?** * **Missing Testing Details:** * "Manual verification" is not sufficient. * Provide specifics: * **Build Host(s):** What operating system, CPU architecture, and compiler were used? * **Target(s):** What architecture (simulator or real hardware), board, and configuration were used? * **Testing logs:** Include relevant logs from **before** and **after** the change to demonstrate the issue and its resolution. **To improve this PR:** 1. **Expand the Summary:** Provide a clear, concise explanation of the problem, the solution, and the code areas affected. 2. **Complete the Impact Assessment:** Address all points with YES/NO and provide detailed explanations where necessary. 3. **Provide Detailed Testing Information:** Specify the build host and target environments, and include relevant testing logs showing the problem and the fix. 4. **Consider Adding a Test Case:** If possible, create a reproducible test case that demonstrates the issue and how your fix resolves it. By providing this information, you make it easier for reviewers to understand and verify your changes, increasing the likelihood of your PR being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
