nuttxpr commented on PR #2709: URL: https://github.com/apache/nuttx-apps/pull/2709#issuecomment-2408583961
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** meet the NuttX requirements. **Missing Information:** * **Purpose of the Change:** The summary only mentions a compiler error being fixed, but doesn't explain why the variable `ret` was unused in the first place. * Was it leftover code? * Did the logic change, making it obsolete? * **Impact Sections are Empty:** You need to analyze and fill out *all* impact sections, even if the answer is "NO". Provide brief explanations when applicable. * **Insufficient Testing Details:** * **Build Host:** Specify the OS, CPU architecture, and compiler version used for building. * **"sim" is too vague:** Which simulator? QEMU? Something else? Be specific about the simulated architecture and board configuration. * **No "Before" Logs:** Without seeing the error message in the "before" logs, it's impossible to verify the fix. **To Improve this PR:** 1. **Expand the Summary:** Clearly explain the reason behind the unused variable and the fix. 2. **Complete the Impact Assessment:** Address each impact category, providing "NO" or a brief explanation if relevant. 3. **Provide Detailed Testing Information:** Include specifics about your build host, the exact simulator configuration, and the relevant "before/after" log snippets demonstrating the error and its resolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
