nuttxpr commented on PR #14197:
URL: https://github.com/apache/nuttx/pull/14197#issuecomment-2408587090

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   The PR summary is missing some key information:
   
   * **What functional part of the code is being changed?**  (e.g., specific 
driver, board configuration, etc.)
   * **How does the change exactly work?** (Briefly describe the technical 
implementation. Did you add a new driver? Modify an existing one?)
   
   **Impact:** 
   
   * The impact section is well-detailed.
   
   **Testing:**
   
   * **Insufficient information:**  
       * You need to provide the actual testing logs before and after the 
change.  "your testing logs here" is not helpful.
       * Be specific about the compiler version used.
       * "ws2812 example application" -  Provide the full path to this 
application within the NuttX apps repository. 
   
   **To summarize:** The PR needs more detail in the summary and testing 
sections to meet the NuttX requirements fully. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to