anchao commented on code in PR #14198: URL: https://github.com/apache/nuttx/pull/14198#discussion_r1797905918
########## libs/libc/machine/arch_atomic.c: ########## @@ -28,7 +28,33 @@ #include <stdbool.h> #include <stdint.h> -#include <nuttx/spinlock.h> +#include <nuttx/irq.h> + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +#ifdef CONFIG_SMP Review Comment: but some architectures may not fully support all atomic operations, eg: -march=armv7e-m does not support atomic8(64 bit) https://github.com/OpenAMP/libmetal/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
