nuttxpr commented on PR #14199: URL: https://github.com/apache/nuttx/pull/14199#issuecomment-2408838342
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX Requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of why using a shared queue reduces memory consumption. * Needs to describe what functional part of the code is being changed beyond "isrthread." * How does `irq_attach_wqueue` work differently from `irq_attach_thread`? * **Impact:** * **Is new feature added? Is existing feature changed?** Specify whether this is a new feature or a modification of an existing one. * **Impact on user:** Does this change require users to adapt their code? Be specific. * **Impact on build:** Will the build process be affected (e.g., new dependencies)? * **Impact on hardware:** Which architectures, boards, or drivers are impacted? * **Impact on documentation:** Does the documentation need updating? Is updated documentation provided in the PR? * **Impact on security, compatibility:** Address these even if there is no impact (e.g., "NO"). * **Testing:** * **Build Host(s):** List the specific operating systems, CPUs, and compilers used for testing. * **Target(s):** Specify the architectures, boards, and configurations tested. * **Testing logs:** Provide actual testing logs from before and after the change. "ci test" is not informative enough. **Recommendations:** 1. **Expand the Summary:** Provide a more detailed explanation of the problem, the solution, and the functional code areas affected. 2. **Complete the Impact Section:** Thoroughly address each impact category, even if it's to state "NO" with a brief explanation. 3. **Provide Specific Testing Details:** Include details about your testing environment and provide actual log output to demonstrate the change's effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
