nuttxpr commented on PR #14222: URL: https://github.com/apache/nuttx/pull/14222#issuecomment-2409871716
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR as presented does **not** meet the NuttX requirements. Here's why and what's missing: * **Insufficient Summary:** * **Vague description:** "Add status information of status reporting frame" is too general. What specific status information is added? What is a "status reporting frame" in this context? * **Missing details:** Which functional part of the code is changed? How exactly does the change work? * **Incomplete Impact Assessment:** * The impact section only mentions "only for lin module." * It needs to address **all** impact points with specifics, even if the answer is NO. For example, explicitly stating "No impact on build process" is better than leaving it to interpretation. * **Absent Testing Details:** * **No build host information:** Which OS, CPU architecture, and compiler version were used for testing? * **Vague target information:** "Cortex-M7 test pass" is not specific enough. Which board and configuration were used? * **Missing logs:** The PR template explicitly requests "Testing logs before change" and "Testing logs after change." These logs provide concrete evidence of the issue and the fix. **To improve the PR:** 1. **Expand the Summary:** * Clearly state the purpose of the change. * Identify the specific files and functions modified. * Explain the technical details of the implementation. 2. **Complete the Impact Assessment:** * Address **all** impact points listed in the template, even if the impact is "NO." * Provide specific details and justification for each impact point. 3. **Provide Thorough Testing Information:** * List the build host environment: OS, CPU, compiler version. * Specify the target(s): Architecture, board, configuration. * Include relevant testing logs from **before** and **after** the change. By providing comprehensive information, you make it easier for maintainers to understand, review, and merge your PR, ultimately benefiting the NuttX project as a whole. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
