nuttxpr commented on PR #14221: URL: https://github.com/apache/nuttx/pull/14221#issuecomment-2409872943
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** meet the NuttX requirements. Here's why: **Missing Information:** * **Summary:** The PR completely lacks a summary. It needs a description of why the changes are necessary, what functional areas are impacted, and how the changes work. * **Impact:** The impact section is not filled out. Each bullet point needs to be addressed, even if the answer is "NO". If the answer is "YES", a detailed explanation is required. * **Testing:** The testing section is incomplete. It needs the following: * Details about your build host system (OS, CPU, Compiler version). * Details about your target system (Architecture, board, configuration). * Testing logs from **before** the change. * Testing logs from **after** the change. **Recommendations:** 1. **Elaborate on the Summary:** For each commit, explain the problem you're solving, the solution you've implemented, and why this solution is chosen. Link any relevant NuttX issues. 2. **Complete the Impact Section:** Analyze the effects of your changes. Do they impact users, the build process, hardware compatibility, documentation, security, or backward/forward compatibility? Provide thorough explanations where necessary. 3. **Provide Testing Details:** Include all requested information about your build and target environments. Demonstrate that your changes work as expected by providing "before" and "after" logs. By filling in the missing information, you will make your PR easier to understand and review, increasing its chances of being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
