nuttxpr commented on PR #14235: URL: https://github.com/apache/nuttx/pull/14235#issuecomment-2409930327
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does not meet the NuttX requirements for the following reasons: * **Summary is insufficient:** * It lacks explanations of **why** these changes are necessary. What problems do they solve? What benefits do they bring? * It lacks details on **how** the changes work. Simply stating "add support" or "new config" isn't informative enough. * **Impact section is dismissive:** * "N/A" is rarely ever true. Every change has *some* impact. * This section needs to specifically address each point (user impact, build impact, hardware impact, etc.) and provide justifications for any "NO" answers. * **Testing is inadequate:** * "ci-check" doesn't tell us what was tested or what the results were. * The PR needs to include: * Specific build hosts and target configurations used for testing. * Relevant log snippets demonstrating the issue before the change and the correct behavior after the change. **In short, this PR needs significant revisions to be considered for merging.** It needs to clearly articulate the motivation for the changes, explain their implementation details, thoroughly analyze their impact, and provide convincing evidence that the changes work as intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
