nuttxpr commented on PR #14238: URL: https://github.com/apache/nuttx/pull/14238#issuecomment-2409959116
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Let's break down if this Pull Request (PR) meets the NuttX requirements. **Summary: The PR seems incomplete based on the provided description.** * **Why is this change necessary?** The description mentions a link error related to `cxx_exception` configuration and `_dl_find_object`. This gives a hint, but it needs more clarity: * Is `cxx_exception` a new configuration? If so, why was it added? * What causes the link error when this configuration is enabled? * Why is `_dl_find_object` the specific solution? * **What is being changed?** State explicitly that the change is the addition of the `_dl_find_object` function. Specify where it's being added (which file/module). * **How does it work?** Briefly explain the function's purpose and how it resolves the link error. **Impact: This section needs more details.** * **New feature?** Is `cxx_exception` (assuming this is the case) a new user-facing feature? * **Impact on...** The PR description currently answers "NO" to all impact questions without elaboration. Given the nature of the change (handling link errors, potentially related to exception handling), there might be impacts on: * **Build:** Does this change the build process in any way (new dependencies, configuration options, etc.)? * **Hardware/Architecture:** Does this change affect specific architectures or boards? * **Compatibility:** Does this affect compatibility with existing codebases that might be using NuttX? * **Security:** Exception handling mechanisms can sometimes have security implications. While this might not be the case here, it's worth considering. **Testing: The testing section needs significant improvement.** * **Provide context:** * What specific "local setup" was used for testing (OS, CPU architecture, compiler, NuttX version)? * Which target architectures and boards were tested? * **Show relevant logs:** * The current PR description has placeholders for logs. You **must** include the actual logs from before and after the change to demonstrate the issue and its resolution. * Focus on the relevant parts of the logs that highlight the error and how your change fixes it. **In summary, this PR needs more work before it can be considered complete.** **Recommendations:** 1. **Expand the Summary:** Provide a clear and concise explanation of the problem, the proposed solution, and the reasoning behind it. 2. **Detail the Impact:** Thoroughly analyze the potential impact of this change on different aspects of NuttX. 3. **Provide Concrete Testing Evidence:** Include detailed information about your testing environment and the relevant logs that demonstrate the problem and the effectiveness of your solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
