(nuttx-apps) branch master updated: Revert "add test for longjump with 0 as return value"

[ligd]

This is an automated email from the ASF dual-hosted git repository.

ligd pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
     new 0e8a6ee2d Revert "add test for longjump with 0 as return value"
0e8a6ee2d is described below

commit 0e8a6ee2d264134348d064aa05f09e9360a98e19
Author: ligd <liguidi...@xiaomi.com>
AuthorDate: Mon Oct 14 12:51:59 2024 +0800

    Revert "add test for longjump with 0 as return value"
    
    This reverts commit 63542f83c2985723071ae7e428311213008aa108.
    
    Signed-off-by: ligd <liguidi...@xiaomi.com>
---
 testing/ostest/setjmp.c | 43 ++++++-------------------------------------
 1 file changed, 6 insertions(+), 37 deletions(-)

diff --git a/testing/ostest/setjmp.c b/testing/ostest/setjmp.c
index 4d5461d36..406756967 100644
--- a/testing/ostest/setjmp.c
+++ b/testing/ostest/setjmp.c
@@ -32,23 +32,17 @@
  * Public Functions
  ****************************************************************************/
 
-void jump_with_retval(jmp_buf buf, int ret)
+void setjmp_test(void)
 {
-  volatile bool did_jump = false;
   int value;
+  jmp_buf buf;
+
+  printf("setjmp_test: Initializing jmp_buf\n");
 
   if ((value = setjmp(buf)) == 0)
     {
       printf("setjmp_test: Try jump\n");
-
-      if (did_jump)
-        {
-          ASSERT(!"setjmp retutns zero after calling longjmp");
-        }
-
-      did_jump = true;
-      printf("setjmp_test: About to jump, longjmp with ret val: %d\n", ret);
-      longjmp(buf, ret);
+      longjmp(buf, 123);
 
       /* Unreachable */
 
@@ -56,32 +50,7 @@ void jump_with_retval(jmp_buf buf, int ret)
     }
   else
     {
-      /* If we provide 0 as the return value to longjmp()
-       * we expect it substitute to 1 for us.
-       */
-
-      if (ret == 0)
-        {
-          ret = 1;
-        }
-
-      ASSERT(value == ret);
+      ASSERT(value == 123);
       printf("setjmp_test: Jump succeed\n");
     }
 }
-
-void setjmp_test(void)
-{
-  jmp_buf buf;
-
-  printf("setjmp_test: Initializing jmp_buf\n");
-
-  jump_with_retval(buf, 123);
-
-  /* Pls ref to:
-   * the longjmp should never make setjmp returns 0
-   * https://pubs.opengroup.org/onlinepubs/009604599/functions/longjmp.html
-   */
-
-  jump_with_retval(buf, 0);
-}