nuttxpr commented on PR #14256: URL: https://github.com/apache/nuttx/pull/14256#issuecomment-2410444552
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to be missing crucial information required by the NuttX contribution guidelines. Here's a breakdown of what's missing and how to address it: **Summary:** * **Insufficient Detail:** "Avoid another layer of function call to get time" is too vague. You must specify: * **Which function call** is being avoided? * **Where** in the codebase is this change located? * **What problem** does this optimization solve (e.g., performance bottleneck, code readability)? **Impact:** * **Overly General:** While the impact might be minor, you *must* still thoroughly assess and document potential effects. Consider: * **Specific functions/modules affected:** Even if the impact is small, list the areas of the code touched by this change. * **Benchmarks (if applicable):** If the goal is optimization, provide concrete evidence (e.g., timing measurements) to demonstrate the improvement. * **Edge Cases:** Are there any unusual scenarios or configurations where this change *might* have unintended consequences? **Testing:** * **Completely Empty:** This section is **mandatory**. You *must* provide: * **Build Host Details:** Operating System, CPU architecture, compiler version (e.g., "Linux, x86_64, GCC 12.2.1"). * **Target Details:** NuttX architecture, board name, configuration (e.g., "ARM, STM32F4 Discovery, hello_world config"). * **Logs:** Include relevant snippets from build logs and runtime output, clearly showing the behavior **before** and **after** your changes. **In addition to the above:** * **Issue References:** If this PR addresses a specific issue in the NuttX or NuttX Apps repositories, provide the issue links. * **Contributing Guidelines:** Thoroughly review the full NuttX [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md) to ensure you haven't missed any other requirements. **Remember:** A well-documented PR is crucial for maintainers to understand, review, and merge your contribution effectively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
