nuttxpr commented on PR #14258: URL: https://github.com/apache/nuttx/pull/14258#issuecomment-2410557160
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** meet the NuttX requirements. Here's why: * **Insufficient Summary:** * The summary lacks a clear explanation of *why* the change is necessary. While it hints at a calculation error, it doesn't explain the consequences of that error. * It mentions a `cfgdescsize` parameter and `ep0 max reqlen`, but doesn't clarify what these are or why they are important. * It's unclear what functional part of the code is being changed beyond "usb3.0 initialization." * There's no mention of related issues or pull requests. * **Incomplete Impact:** * The impact section only mentions "usb3.0," which is too vague. It needs to specify: * Is this a new feature, a bug fix, or an enhancement? * Which architectures, boards, or drivers are affected? * Will users need to adapt to the change? * Will the build process or documentation be affected? * Are there security implications? * Will this affect compatibility? * **Insufficient Testing:** * Simply stating "selftest" isn't enough. The PR needs to provide: * Details about the testing environment (host OS, CPU, compiler, target architecture, board, configuration). * Relevant logs from *before* the change to demonstrate the issue. * Relevant logs from *after* the change to demonstrate that the issue is resolved. **To improve this PR:** 1. **Expand the Summary:** Clearly articulate the problem, the solution, and the affected code areas. Include links to relevant issues or PRs. 2. **Complete the Impact:** Provide specific details about how the change affects users, the build, hardware, documentation, security, and compatibility. 3. **Thoroughly document testing:** List all testing environments, and include relevant "before" and "after" logs that clearly illustrate the problem and the fix. By providing this information, the PR will be easier to understand, review, and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
