cederom commented on code in PR #2718:
URL: https://github.com/apache/nuttx-apps/pull/2718#discussion_r1799962399
##########
benchmarks/dhrystone/CMakeLists.txt:
##########
@@ -44,7 +44,10 @@ if(CONFIG_BENCHMARK_DHRYSTONE)
endif()
endif()
- set(CFLAGS -DMSC_CLOCK)
+ set(CFLAGS
Review Comment:
I mean local patches can be applied to the fetched release package before
the build here for NuttX. We should patch the code not hide the build problems.
That way also external dependency upstream can be fixed and we need no patches
next time :-)
Look some patches are already applied to dhrystone:
https://github.com/apache/nuttx-apps/blob/master/benchmarks/dhrystone/Makefile
The same with coremark:
https://github.com/apache/nuttx-apps/tree/master/benchmarks/coremark
Would it be possible to fix the issue with a code fix patch @lipengfei28
please ? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
