cederom commented on PR #2708: URL: https://github.com/apache/nuttx-apps/pull/2708#issuecomment-2412364313
My only remark is this is very useful feature, probably will be developed further in future, but as for quite a big change better description in the PR and some additional comments in the commit message would help understand the change better by others that want to use it too :-) * Is existing API impacted anyhow? Will old code work the same way or needs an update? * Is documentation update required / necessary? Maybe it would be good to provide documentation on how to use new functionalities? Newcomers tend to start at documentation so share your inventions there too :-) * If the buffer is too small, sure we can increase the buffer, but also overflow checks are necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
