nuttxpr commented on PR #14277: URL: https://github.com/apache/nuttx/pull/14277#issuecomment-2412648174
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of why the change is necessary. What redundancy is being removed? * Does not specify the functional part of the code being changed. * Does not explain how the change works or what exactly will be removed. * No related issue references. * **Impact:** * While stating "none," it's crucial to confirm if this change affects any specific architectures, boards, or drivers within the arm/riscv context. * **Testing:** * "ci test" is insufficient. * Provide specific build host details (OS, CPU, compiler). * Specify the target architecture (sim, RISC-V, ARM) and board configurations used for testing. * Include relevant snippets of testing logs demonstrating the issue before and the improvement after the change. **To improve this PR:** 1. **Expand the Summary:** Clearly articulate the problem (redundant judgment), its location, how the change addresses it, and link any relevant issues. 2. **Review Impact:** Even if minimal, confirm the impact on specific arm/riscv components (architectures, boards, drivers). 3. **Provide Detailed Testing Information:** List specific build hosts and target environments. Include relevant log excerpts showing the redundancy before and its successful removal after the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
