nuttxpr commented on PR #2724: URL: https://github.com/apache/nuttx-apps/pull/2724#issuecomment-2412667555
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is good, but the other sections could be improved. Here's a breakdown with suggestions: **Summary:** 👍 * Clearly explains the problem (`nuttx/arch.h` causes unnecessary headers to be included). * Describes the solution (removing the inclusion and adding missing headers in `nuttx-apps`). **Impact:** 👎 (Needs more details) * **Is new feature added? Is existing feature changed?** -> No, this is a bug fix. * **Impact on user (will user need to adapt to change)?** -> Likely NO, but be explicit. Does this affect any user-facing APIs? * **Impact on build (will build process change)?** -> Potentially YES, since headers are modified. Specify which parts of the build process might be affected. * **Impact on hardware (will arch(s) / board(s) / driver(s) change)?** -> NO * **Impact on documentation (is update required / provided)?** -> Possibly YES if the affected headers are documented. * **Impact on security (any sort of implications)?** -> NO, unless the unnecessary headers posed a security risk. * **Impact on compatibility (backward/forward/interoperability)?** -> Unlikely, but be explicit. Does this affect compatibility with older NuttX versions or external tools? **Testing:** 👎 (Not enough information) * **Build Host(s):** Provide details: OS, CPU architecture, compiler version. * **Target(s):** Specify the exact boards and configurations tested on QEMU/arm64 and QEMU/x86_64. * **Testing logs:** The logs are essential! Include relevant snippets showing the compilation errors before the change and successful compilation after the change. **Overall:** The PR needs more details in the "Impact" and "Testing" sections to meet NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
