nuttxpr commented on PR #14280: URL: https://github.com/apache/nuttx/pull/14280#issuecomment-2412830610
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR appears to be missing critical information required by the NuttX contribution guidelines. Here's a breakdown: **Missing Information** * **Summary:** * **Why?** The PR lacks a clear explanation of why adding board reset support and initializing the PCI ecam in qemu-armv8a is necessary. Is this fixing a bug? Improving emulation accuracy? Enabling new functionality? * **What/How?** A technical description of the implementation is missing. How is board reset being achieved? How is the PCI ecam initialized, and what are the specific code changes involved? * **References:** Are there related NuttX issues, discussions, or similar implementations that provide context? * **Impact:** * While the PR mentions "arm64" and "qemu-armv8a," it doesn't detail the impact on: * **Users:** Will users need to change configurations, experience different behavior, or have new capabilities? * **Build:** Are there build system changes, new dependencies, or configuration options introduced? * **Hardware/Drivers:** Does this affect support for specific hardware or require driver modifications? * **Documentation:** Is documentation updated to reflect these changes? * **Security/Compatibility:** Any security implications or compatibility concerns (backward/forward)? * **Testing:** * **Verification Details:** The PR provides no information on how the changes were tested. * **Environment:** Details about the build host (OS, compiler) and the target QEMU configuration (board, machine type) are essential. * **Logs:** "Before" and "after" logs demonstrating the changes' effect are crucial for reviewers to understand the impact and verify correctness. **Action Items for PR Author** 1. **Elaborate on the "Summary" section:** Provide a clear rationale for the changes, explain the technical implementation, and include relevant references. 2. **Complete the "Impact" section:** Analyze the potential impact on all aspects mentioned in the guidelines, providing specific details where applicable. 3. **Thoroughly document "Testing":** Describe the testing methodology, specify the build host and target environments, and include relevant logs showcasing the changes' effects. By addressing these points, the PR will significantly improve in clarity, allowing reviewers to assess its value and ensure it aligns with NuttX's standards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
