xiaoxiang781216 commented on code in PR #14284: URL: https://github.com/apache/nuttx/pull/14284#discussion_r1800462559
########## libs/libc/gdbstub/lib_gdbstub.c: ########## @@ -53,7 +53,7 @@ #define BUFSIZE CONFIG_LIB_GDBSTUB_PKTSIZE #ifdef CONFIG_BOARD_MEMORY_RANGE -FAR const struct memory_region_s g_memory_region[] = +FAR static const struct memory_region_s g_memory_region[] = Review Comment: remove FAR ########## sched/misc/coredump.c: ########## @@ -92,7 +92,7 @@ static unsigned char *g_blockinfo; #endif #ifdef CONFIG_BOARD_MEMORY_RANGE -static struct memory_region_s g_memory_region[] = +static const struct memory_region_s g_memory_region[] = Review Comment: can't use const, the code may modify it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
