nuttxpr commented on PR #14289: URL: https://github.com/apache/nuttx/pull/14289#issuecomment-2412923896
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to be **missing information** to meet the NuttX requirements. **Here's why and what's lacking:** * **Summary:** * **Too vague.** "Follow the same pattern" and "code refactor" are not informative enough. * **What pattern?** Which Make.defs files are being used as reference? * **What was refactored and how?** Be specific about the changes made to the code. * **Impact:** * **"Code refactor only" needs more detail.** Even refactors can have unintended consequences. * **Consider all impact points.** While the PR might not introduce new features or hardware changes, think about potential impacts on: * **Build:** Did the refactoring change any build dependencies or processes? * **Compatibility:** Could the refactoring cause issues with older NuttX versions or configurations? * **Testing:** * **"ci" is insufficient.** * **Provide specific details about your local testing:** * List the host OS, CPU architecture, and compiler used. * Specify the target architecture, board, and configuration. * **"Testing logs" are missing.** Include relevant logs from *before* and *after* your changes to demonstrate the problem and the solution. **To improve this PR:** 1. **Expand the Summary:** Provide specific details about the code refactoring, the pattern being followed, and the files affected. 2. **Thoroughly analyze the Impact:** Don't assume a refactor has zero impact. Address all points, even if it's to confirm "NO" with a brief explanation (e.g., "No impact on build process, the refactoring only affected code structure within a single file"). 3. **Provide Complete Testing Information:** Follow the template and replace the placeholders with your actual testing environment and logs. By addressing these points, your PR will be clearer, easier to review, and more likely to be merged quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
