nuttxpr commented on PR #2728: URL: https://github.com/apache/nuttx-apps/pull/2728#issuecomment-2413121174
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This Pull Request does not meet the NuttX requirements. **Here's why and how to fix it:** * **Insufficient Summary:** * The summary provides a title but lacks crucial details. You need to explain: * **Why?** Why are these x86_64 ABI test cases necessary? Are they fixing a bug, adding a new feature, or improving existing functionality? * **What?** Be more specific about the functional changes. What aspects of the x86_64 ABI are being tested? * **How?** Briefly describe the testing methodology or the types of test cases added. * **Provide Links:** If applicable, link to relevant NuttX issues that this PR addresses. * **Impact - Overly Simplistic:** * While "No" might be the answer to some impact questions, you **must** provide details when impact exists: * **New Feature?** If these tests introduce a new feature or significantly alter existing ones, explain the feature and its purpose. * **Build Impact?** Do these tests require changes to the build system, new dependencies, or configuration options? * **Hardware Impact?** Are these tests specific to certain x86_64 hardware configurations? * **Documentation?** New tests often necessitate documentation updates to explain their usage, purpose, and interpretation of results. * **Testing - Unacceptable:** * **"No" is not an option.** You *must* provide evidence that your changes work as intended. This includes: * **Detailed Test Setup:** Specify the *exact* build hosts (OS, CPU, compiler versions) and target environments (architecture, board, configurations) used for testing. * **Before/After Logs:** Provide relevant snippets of testing logs that demonstrate the issue *before* your changes and the successful outcome *after* your changes. **Example of an Improved Summary:** ```markdown ## Summary This PR adds a suite of x86_64 ABI test cases to the `app/testing` directory to address [link to NuttX issue if applicable]. The test cases cover [mention specific areas of the ABI tested, e.g., calling conventions, register preservation, structure packing] and aim to improve the robustness and reliability of NuttX on x86_64 platforms. The tests are implemented using [briefly describe the testing framework or methodology, e.g., unity, custom test harness]. ``` **Remember:** A well-written PR is crucial for maintainers to understand, review, and merge your code efficiently. Take the time to provide all the necessary information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
