anchao commented on a change in pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345#discussion_r448308618



##########
File path: tools/Makefile.unix
##########
@@ -421,7 +421,7 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
                cp -f uImage /tftpboot/uImage; \
        fi
 endif
-       $(call POSTBUILD)
+       $(call POSTBUILD, $(TOPDIR))

Review comment:
       > Similar change needs to be done to the Makefile.win.
   Got.
   
   > Out of curiosity, are you using TOPDIR in your POSTBUILD script to move 
around the final BIN?
   Yes, just to improve compatibility, postbuild will require different BIN 
directories in some scenarios on out platform.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to