xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448336994
##########
File path: include/nuttx/compiler.h
##########
@@ -255,15 +255,6 @@
# undef CONFIG_PTR_IS_NOT_INT
#endif
-/* GCC supports inlined functions for C++ and for C version C99 and above */
-
-# if defined(__cplusplus) || (defined(__STDC_VERSION__) && __STDC_VERSION__
>= 199901L)
Review comment:
Since inline doesn't work well in the old compiler, you can see each
place which reference CONFIG_HAVE_INLINE have to provide two versions: one is
inline function and another is macro which make the simple thing complex(@yamt
and I have the same feeling). The better approach is:
1.Remove CONFIG_HAVE_INLINE
2.Implement the function as a normal(no inline) function as much as possible
3.For the simple and performance critical function:
a.Implement as the macro if it is an internal function
b.C standard function(like isspace) provide two versions:
1.Inline version if __cpluscplus__ define
2.Macro verson if __cpluscplus__ not define
Note: 3.b is required because the c++ library often write "using ::isspace"
which is incompatible with macro.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
