nuttxpr commented on PR #14364: URL: https://github.com/apache/nuttx/pull/14364#issuecomment-2416627269
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## PR Requirements Review The provided summary is good, clearly explaining the issue, its impact, and the proposed solution. However, the PR lacks some key information to be considered complete against the NuttX requirements: **Missing Information:** * **Testing:** * **Insufficient Detail:** "rv-virt:knsh64 + modifications" is too vague. Please list the exact `CONFIG_` options used for both build host and target. * **No Logs:** You **must** provide actual testing logs before and after the change. This is crucial to demonstrate the issue and the effectiveness of your fix. * **Impact:** * **User Impact?** Will users need to change anything in their applications or build process due to this fix? Be specific. * **Documentation:** Does this change require any documentation updates? If so, are they provided in this PR? **Recommendations:** 1. **Expand Testing Section:** Provide detailed build host and target configurations (including specific `CONFIG_` options). Include actual testing logs demonstrating the issue before the fix and the successful outcome after. 2. **Clarify User Impact:** Specify if any user action is needed (e.g., rebuilding applications, configuration changes) and provide clear instructions if so. 3. **Address Documentation:** If documentation updates are required, include them in the PR or create a separate issue/PR for them and link it here. **Overall:** The PR addresses a relevant issue with a clear solution. However, it lacks sufficient testing details and clarity on user impact to be considered complete against the NuttX requirements. Providing the missing information will significantly strengthen the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
