nuttxpr commented on PR #14365: URL: https://github.com/apache/nuttx/pull/14365#issuecomment-2416748876
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * **Why** is the change necessary? What problem does it solve? * **What** functional part of the code is being changed? Be specific. * **How** does the change work? Provide a technical explanation. * **Impact:** * The impact section is too vague. Provide specific details about the impact on: * **Users:** Will they need to change anything? * **Build process:** Any changes required? * **Hardware:** Any affected architectures, boards, or drivers? * **Documentation:** Does it need updating? * **Security, compatibility:** Any implications? * **Testing:** * **Insufficient information:** * Provide details about your local setup: OS, CPU, compiler, target architecture, board, configuration. * Include relevant **before and after testing logs** that demonstrate the issue and the fix. "ci" is not sufficient. **Recommendations:** 1. **Expand the Summary** section with detailed information about the problem, the solution, and the technical implementation. 2. **Provide specific details** in the Impact section for each category. 3. **Thoroughly document your testing environment** and include relevant testing logs that show the problem before the change and the successful outcome after the change. A well-structured and informative PR will significantly increase the chances of your contribution being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
