nuttxpr commented on PR #14373: URL: https://github.com/apache/nuttx/pull/14373#issuecomment-2418093783
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is good, but it lacks specific details about the change and its usage. The impact and testing sections are too vague. Here's how the PR description could be improved to better meet the requirements: **Summary** * **Why change is necessary (fix, update, new feature)?** - This PR adds a new configuration option to the IMX9 FlexCAN driver to enable/disable the "self-receive disable" feature. - This feature is useful in applications where the CAN controller should not receive the frames it transmits itself, preventing potential issues with looped-back messages. * **What functional part of the code is being changed?** - Modification to the IMX9 FlexCAN driver code, specifically the configuration handling section. * **How does the change exactly work (what will change and how)?** - A new Kconfig option will be introduced to enable/disable "self-receive disable" functionality. - When enabled, the driver will set the appropriate bit in the FlexCAN hardware registers to prevent self-reception. - When disabled, the feature will be inactive, and the FlexCAN controller will operate in its default mode, receiving both self-transmitted and externally received frames. * **Related [NuttX Issue](https://github.com/apache/nuttx/issues) reference if applicable.** (Add issue link if applicable) **Impact** * **Is new feature added? Is existing feature changed?** - YES, a new configuration option for the "self-receive disable" feature is added to the IMX9 FlexCAN driver. * **Impact on user (will user need to adapt to change)?** YES - Users now have the option to enable or disable the "self-receive disable" feature through the Kconfig option. - Users should consult the updated documentation to understand the new configuration option and its impact on their application. * **Impact on build (will build process change)?** NO * **Impact on hardware (will arch(s) / board(s) / driver(s) change)?** NO * **Impact on documentation (is update required / provided)?** YES - The IMX9 FlexCAN driver documentation should be updated to include information about the new "self-receive disable" configuration option and its usage. * **Impact on security (any sort of implications)?** NO * **Impact on compatibility (backward/forward/interoperability)?** NO * **Anything else to consider?** NO **Testing** * **Build Host(s):** (Specify your build host details: OS, CPU, compiler version) * **Target(s):** imx93 (custom board) **Testing logs before change:** ``` (Include relevant logs demonstrating the previous behavior, like self-transmitted frames being received) ``` **Testing logs after change:** ``` (Include relevant logs demonstrating the new behavior with "self-receive disable" both enabled and disabled, showcasing the difference in frame reception) ``` By providing specific details about the changes, configuration options, and testing scenarios, the PR becomes clearer, easier to review, and more likely to be accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
