This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 9c6c56c25578f5e43da8a199e7884ef1aa97ad41
Author: Neo Xu <[email protected]>
AuthorDate: Wed Oct 16 15:03:11 2024 +0800

    mempool: use backtrace_format
    
    There's no need to manually format the backtrace any more.
    
    Signed-off-by: Neo Xu <[email protected]>
---
 mm/mempool/mempool.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/mm/mempool/mempool.c b/mm/mempool/mempool.c
index cfac830743..655906f4ea 100644
--- a/mm/mempool/mempool.c
+++ b/mm/mempool/mempool.c
@@ -197,20 +197,13 @@ static void mempool_memdump_callback(FAR struct mempool_s 
*pool,
   if ((MM_DUMP_ASSIGN(dump, buf) || MM_DUMP_ALLOC(dump, buf) ||
        MM_DUMP_LEAK(dump, buf)) && MM_DUMP_SEQNO(dump, buf))
     {
-      char tmp[BACKTRACE_BUFFER_SIZE(CONFIG_MM_BACKTRACE)];
-
 #  if CONFIG_MM_BACKTRACE > 0
-      FAR const char *format = " %0*p";
-      int i;
+      char tmp[BACKTRACE_BUFFER_SIZE(CONFIG_MM_BACKTRACE)];
 
-      for (i = 0; i < CONFIG_MM_BACKTRACE &&
-                      buf->backtrace[i]; i++)
-        {
-          snprintf(tmp + i * BACKTRACE_PTR_FMT_WIDTH,
-                   sizeof(tmp) - i * BACKTRACE_PTR_FMT_WIDTH,
-                   format, BACKTRACE_PTR_FMT_WIDTH - 1,
-                   buf->backtrace[i]);
-        }
+      backtrace_format(tmp, sizeof(tmp), buf->backtrace,
+                       CONFIG_MM_BACKTRACE);
+#  else
+      FAR const char *tmp = "";
 #  endif
 
       syslog(LOG_INFO, "%6d%12zu%12lu%*p%s\n",

Reply via email to