raiden00pl commented on code in PR #14404:
URL: https://github.com/apache/nuttx/pull/14404#discussion_r1806506875
##########
cmake/nuttx_toolchain.cmake:
##########
@@ -23,6 +23,13 @@
# search. If the manual of the newly supported toolchain is different, you can
# override these methods in the toolchain
+if("${CMAKE_C_COMPILER_ID}" STREQUAL "GNU")
Review Comment:
OK, I know know. This implementation is wrong. `CMAKE_C_COMPILER_ID` is
valid only after `project()` call
##########
cmake/nuttx_toolchain.cmake:
##########
@@ -23,6 +23,13 @@
# search. If the manual of the newly supported toolchain is different, you can
# override these methods in the toolchain
+if("${CMAKE_C_COMPILER_ID}" STREQUAL "GNU")
Review Comment:
OK, I know now. This implementation is wrong. `CMAKE_C_COMPILER_ID` is valid
only after `project()` call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
