nuttxpr commented on PR #14423: URL: https://github.com/apache/nuttx/pull/14423#issuecomment-2425553031
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of why the change is necessary. What duplication is being addressed? * Needs a description of the functional part of the code being changed. * Requires details on how the change works. * **Impact:** * While "Remove duplicated code" is a start, it needs more specifics. Which architectures, boards, or drivers are affected? * Consider all impact points: user impact, build impact, documentation, security, compatibility. Even if the answer is "NO," state it explicitly for each. * **Testing:** * "ci" is not sufficient. * Provide specific details about your build host(s) and target(s). * Include actual testing logs before and after the change to demonstrate the issue and the fix. **Recommendations:** 1. **Expand the Summary:** Clearly articulate the problem (code duplication), the solution (moving conversion to a common layer), and the specific code sections involved. 2. **Detail the Impact:** Address each impact point, even if it's to say "NO." If there's no user impact, state "Impact on user: NO." This demonstrates you've considered all aspects. 3. **Provide Comprehensive Testing Information:** * List the OS, CPU, compiler, architecture, board, and configuration used for testing. * Include relevant snippets from your testing logs that highlight the problem before the change and the improvement after. **Remember:** A good PR is thorough and easy for reviewers to understand. Providing complete information ensures a smoother review process and a higher chance of your PR being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
