nuttxpr commented on PR #14433: URL: https://github.com/apache/nuttx/pull/14433#issuecomment-2426577265
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of the functional code changes. * Needs to specify how the GCCVER issue was fixed. * **Impact:** * "libcxx" is not a sufficient description. * Needs specific details on the impact across all categories (user, build, hardware, documentation, security, compatibility). * **Testing:** * "ci test" is not acceptable. * Provide specific build host details (OS, CPU, compiler version). * List the target architectures and boards used for testing. * Include actual testing logs (before and after) demonstrating the issue and the fix. **Recommendations:** 1. **Expand the Summary:** Clearly describe the technical changes made to fix the GCCVER definition in CMake. 2. **Complete the Impact Section:** Address each impact category with "YES" or "NO". If "YES", provide a detailed explanation. For example: * **Impact on build:** YES - The build process is now more robust as it will correctly identify the GCC version. 3. **Provide Detailed Testing Information:** * List all build hosts used, including OS, CPU, and compiler details. * Specify the target architectures and boards where the issue was observed and the fix was verified. * Include relevant snippets from your testing logs that clearly show: * The error messages encountered before the fix. * The successful build and execution after applying the fix. By providing this essential information, your PR will be more likely to be reviewed and merged quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
