nuttxpr commented on PR #14439: URL: https://github.com/apache/nuttx/pull/14439#issuecomment-2427318136
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not fully meet the NuttX requirements.** Here's why and how to improve it: * **Missing details in Summary:** * **Why is the change necessary?** Clearly state the problem the PR addresses. For example: "CMake builds were failing for nucleo-f722ze and nucleo-f746zg/pysim boards due to [explain the root cause of the break]." * **How does the change work?** Briefly explain the technical approach taken to fix the CMake build issue. * **Impact Section:** * **Is new feature added? Is existing feature changed?** - Since this is a bug fix, it's not a new feature. Specify that an existing feature (the build system for specific boards) is being fixed. * **Impact on user:** This likely has no user impact beyond fixing a broken build. If so, state that explicitly. * **Impact on build:** Be more specific than "unlock CI." Explain what part of the build process was affected and how the change resolves it. * **Other impacts:** Most of the other impacts are probably "NO" but confirm this in your PR. * **Testing:** * **Provide more context:** * Specify the exact versions of CMake and Make used for testing. * For "Target(s)", be explicit about the configurations tested on each board (e.g., "nucleo-f722ze:nsh"). * **No logs included:** You need to include actual build logs (both before and after the change) to demonstrate the issue and the fix. Trim the logs to show only the relevant error messages and the successful build output after your changes. **Recommendations:** 1. **Expand the Summary** to clearly explain the problem and your solution. 2. **Be specific in the Impact section**, particularly regarding build changes. 3. **Include relevant build logs** to demonstrate the problem and the fix. By addressing these points, your PR will be much more informative and easier for maintainers to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
