nuttxpr commented on PR #14455: URL: https://github.com/apache/nuttx/pull/14455#issuecomment-2429314812
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## NuttX PR Requirements Review The provided PR description is **missing crucial information** to meet the NuttX requirements. **Here's a breakdown:** **Summary:** * **Missing:** A clear explanation of **why** this change is necessary. Is it fixing a bug? Enhancing performance? Provide context. * **Insufficient:** "Some project..." is too vague. Specify **which** projects/configurations are affected by this issue. * **Missing:** How does the use of 33-bit PC-relative addressing **specifically** solve the described problem? **Impact:** * **Incomplete:** The impact section is entirely blank. You **must** address each point, stating "NO" or providing a detailed explanation if "YES". Consider: * **Users:** Will any user code need modification? * **Build:** Will any build flags or configurations be affected? * **Hardware:** Which architectures/boards are impacted? * **Documentation:** Does this change require documentation updates? * **Security:** Are there any potential security implications of this change? * **Compatibility:** Does this affect compatibility with older NuttX versions, different architectures, or external tools? **Testing:** * **Completely Missing:** You **must** provide: * Details about your build host environment (OS, CPU, compiler version) * Details about the target(s) you tested on (architecture, board, configuration) * Build logs (ideally, with `make V=1`) from **before** and **after** the change * Relevant runtime logs demonstrating the issue and the fix **Recommendations:** 1. **Expand the Summary:** Clearly explain the problem, the solution, and why it's important. 2. **Complete the Impact Section:** Address each point thoroughly, even if it's just "NO". 3. **Provide Detailed Testing Information:** Show evidence that your change works as intended. Include build logs, runtime logs, and specific details about your testing environment. By providing this missing information, you'll make your PR much easier to review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
