nuttxpr commented on PR #14461: URL: https://github.com/apache/nuttx/pull/14461#issuecomment-2429528246
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not fully meet the NuttX requirements.** Here's why and how to improve it: **Missing Information** * **Summary:** * **Why is this change necessary?** Clearly state the problem caused by the malloc/free inconsistency. Explain why `strndup` and `fs_heap_free` mismatch. * **How does `fs_heap_strndup` solve this?** Provide a concise explanation of the new function's behavior. * **Impact:** * You need to analyze and address **all** impact points. Even if an area is not affected, state "NO" explicitly. Don't leave sections blank. * **Examples of potential impact (you need to confirm these):** * **Impact on user:** Will any applications using `strndup` need to be modified? * **Impact on build:** Were any new dependencies introduced by `fs_heap_strndup`? * **Impact on hardware:** Likely NO, but confirm this. * **Impact on documentation:** Does the addition of `fs_heap_strndup` require documentation updates? * **Testing:** * **Insufficient Detail:** "sim" is not enough information. * **Provide:** * **Specific simulator used:** e.g., `qemu-system-arm`, `qemu-system-riscv64`, etc. * **NuttX configuration:** Which board configuration within the simulator (`sim:nsh`, `sim:last`, etc.)? * **Testing logs:** You must include relevant log snippets showing: * **The issue before the change.** * **The issue resolved after the change.** **How to Improve the PR Description** 1. **Expand the Summary:** Provide a clear and concise explanation of the problem and the solution. 2. **Complete the Impact Assessment:** Address all impact categories, even if they are not affected (state "NO"). 3. **Provide Detailed Testing Information:** Specify the simulator, configuration, and include relevant before/after log snippets. By providing this missing information, you'll make it much easier for reviewers to understand and evaluate your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
