nuttxpr commented on PR #2487: URL: https://github.com/apache/nuttx-apps/pull/2487#issuecomment-2430723684
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## PR Requirements Review **Meeting Requirements?** Partially **Summary:** * **Why?** Provides a more common and ecosystem-friendly way to build Rust applications for NuttX. * **What?** Introduces cargo as a build method for Rust applications. * **How?** Leverages nightly Rust versions supporting NuttX as a direct target. Provides a hello world example. * **Issues/PRs:** None linked. **Impact:** * **New Feature:** YES (cargo-based build) * **User Impact:** YES (Need nightly Rust, specific target config, potential future changes due to TODOs) * **Build Impact:** YES (Requires cargo, nightly Rust toolchain) * **Hardware Impact:** Potentially, depending on target triple support. * **Documentation Impact:** YES (Required for new build process, Rust support) * **Security Impact:** Unclear, requires further analysis of Rust integration. * **Compatibility Impact:** Potential forward compatibility issues due to reliance on nightly Rust. **Testing:** * **Incomplete:** Only mentions target architecture, not specific boards or configurations tested on. * **Logs:** Missing. ## Specific Concerns * **Rust Integration Maturity:** Heavy reliance on nightly Rust and upstreaming efforts (libc, libstd) indicates this is an early-stage integration. PR should clearly communicate this. * **TODOs:** The extensive TODO list suggests this is a work in progress. It's important to clarify the scope of this specific PR versus future work. * **Target Specificity:** The PR should clearly document supported target triples and any limitations. * **Testing:** More comprehensive testing is needed across various architectures, boards, and configurations. Provide detailed logs. * **Documentation:** This is crucial for a new build system and language integration. Detailed instructions, configuration options, and limitations should be included. ## Recommendation This PR addresses a desirable feature but is not yet ready for merging in its current state. Address the concerns outlined above to ensure a robust, well-documented, and well-tested addition to NuttX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
