nuttxpr commented on PR #14482:
URL: https://github.com/apache/nuttx/pull/14482#issuecomment-2432076318

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **Meets Requirements?** 
   
   No. 
   
   **Missing Information:**
   
   * **Summary:**
       * **What functional part of the code is being changed?**  Be specific. 
Which board files incorrectly included this header? 
       * **How does the change exactly work?**  Did you remove the include? 
Replace it with something else?
   * **Impact:**
       * **Impact on user:** You state "minor" but don't explain. Will *any* 
users be affected? Will this fix a bug they experience? 
       * **Impact on build:**  If the include was incorrect, will the build now 
succeed where it failed before? Be specific about the impact.
   * **Testing:**
      * **Build Host(s):** Provide details about your build environment.
      * **Target(s):** Specify the architecture and board configurations you 
tested on.
      * **Testing Logs:**  "CI" is not sufficient.  Provide snippets of the 
relevant log output before and after your change to demonstrate the problem and 
the fix.
   
   **Recommendations:**
   
   * Provide the missing specifics outlined above. 
   * Consider adding a "Fixes #[issue number]" line to your Summary if this PR 
directly addresses an existing issue. 
    
   A more complete PR will ensure your contribution is reviewed and merged 
quickly! 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to