nuttxpr commented on PR #14497: URL: https://github.com/apache/nuttx/pull/14497#issuecomment-2434915025
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR, as described, does not meet the NuttX requirements. Here's why: **Missing Information** * **Insufficient Summary:** While it mentions the problem ("can't do sem_post/wait within spinlock") and the solution ("revert"), it lacks a clear explanation of *why* the previous change was made (PR #11769) and *what* specific issue the revert addresses. * **Vague Impact:** Simply stating "rw sem" is not informative enough. The impact section needs to specifically describe how this revert affects the user, build process, hardware, documentation, security, and compatibility. * **Lack of Testing Details:** The testing section mentions "fs test" but doesn't provide any specifics. * What "fs test" was used? * What were the actual test commands? * What were the expected results vs. the actual results? * What build hosts and targets were used for testing? **Recommendations for Improvement** 1. **Expand the Summary:** * Explain the rationale behind the original change (PR #11769) and why it was problematic. * Clearly describe the specific issue caused by the previous change and how this revert resolves it. 2. **Detailed Impact Analysis:** * Address *all* impact points specifically. If no impact is expected, state that clearly (e.g., "Impact on build: NO"). * If there is an impact, provide details. For example, if the revert affects backward compatibility, explain how and with which versions. 3. **Thorough Testing Information:** * Specify the build hosts used (OS, CPU, compiler versions). * List the target architectures and boards used for testing. * Provide the exact test commands or scripts used. * Include the full testing logs (before and after the change) in a clear and readable format. Highlight the relevant sections that demonstrate the issue and its resolution. By providing this missing information, the PR will better adhere to the NuttX requirements, making it easier for maintainers to review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
