nuttxpr commented on PR #14503: URL: https://github.com/apache/nuttx/pull/14503#issuecomment-2436758701
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## NuttX PR Requirements Review: **Verdict:** This PR appears **incomplete** based on the provided information. **Reasons:** * **Summary:** While it explains the technical change, it lacks context. * **What problem does this fix?** Is `this_cpu()` causing a bug? If so, describe it. * **Which hardware registers are affected?** Be specific. * **Impact:** Dismissing all impact with "N/A" is rarely accurate. Consider these: * **Hardware:** You explicitly mention "hardware register calculation". Which architectures/boards use GICv3 and are thus affected? * **Compatibility:** Could this change break existing drivers or configurations that rely on the old behavior? * **Testing:** * **"ci-check" is insufficient.** Provide: * **Specific build hosts & targets** used for verification * **Actual test logs** (before/after) demonstrating the problem and its resolution. * **What was the expected behavior vs. the actual behavior before the fix?** **Recommendations:** 1. **Expand the Summary** with clear problem description, affected hardware, and benefits of the change. 2. **Thoroughly analyze Impact**. Even if the answer is "NO" for most, *justify* it briefly (e.g., "No impact on documentation, as this is a purely internal code change"). 3. **Provide detailed testing information.** This is crucial for reviewers to assess the validity of your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
