haiyuewa commented on code in PR #14505:
URL: https://github.com/apache/nuttx/pull/14505#discussion_r1816079429
##########
arch/x86_64/src/common/Toolchain.defs:
##########
@@ -106,6 +106,12 @@ ifeq ($(CONFIG_DEBUG_LINK_WHOLE_ARCHIVE),y)
LDFLAGS += --whole-archive
endif
+ifeq ($(CONFIG_HOST_LINUX),y)
Review Comment:
> if so, CONFIG_HOST_LINUX should drop since CONFIG_HOST_xxx is only
meaningful for sim arch.
I changed it as the build bug fix : b5d640acc5b3 ("fix Cygwin/MSYS2 ld:
unrecognized option '-z'")
Is it about build system ? Since adding it will also make the patch work.
-l selects the Linux (l) host environment.
-m selects the macOS (m) host environment.
-c selects the Windows host and Cygwin (c) environment.
-g selects the Windows host and MinGW/MSYS environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
