xiaoxiang781216 commented on code in PR #14510: URL: https://github.com/apache/nuttx/pull/14510#discussion_r1817638039
########## drivers/syslog/syslog_channel.c: ########## @@ -235,10 +235,9 @@ static int syslog_default_putc(FAR syslog_channel_t *channel, int ch) UNUSED(channel); # ifdef CONFIG_ARCH_LOWPUTC - return up_putc(ch); -# else - return ch; + up_putc(ch); # endif + return ch; Review Comment: should we remove the return value from the callback in syslog_channel_s? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
