nuttxpr commented on PR #14528: URL: https://github.com/apache/nuttx/pull/14528#issuecomment-2440861476
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR appears to meet the NuttX requirements: * **Summary:** Clearly describes the issues fixed (incorrect file pointer in append mode and attribute offset issue in NFS). * **Impact:** Concisely explains the impact as improved NFS behavior. While not overly detailed, the test program suggests this fix aligns NFS with expected file system operations, likely not requiring user adaptation. The impact sections (build, hardware, documentation, etc.) are implicitly addressed as "NO" by omission, which is acceptable if no changes are expected in those areas. * **Testing:** Provides sufficient detail on the testing environment (simulator, specific NFS mount command) and includes a clear test program. The "before" and "after" logs effectively demonstrate the issue and its resolution. **Recommendation:** To further strengthen the PR, consider adding a brief comment explicitly stating that the impact sections are not applicable (e.g., "No changes to build process, hardware, documentation, etc."). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
