nuttxpr commented on PR #14530: URL: https://github.com/apache/nuttx/pull/14530#issuecomment-2440968519
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** Here's why and how to improve it: **Missing Information:** * **Summary:** * **Why?** What problem does enabling compiler-rt solve? What benefits does it bring? * **What/How?** Be more specific about the code changes. Which files are modified? What configuration options are affected? Provide a code snippet if possible. * **Impact:** * You need to address **all** impact points with either "NO" or "YES (and explanation)". Don't leave any blank. Consider these questions: * **Build:** Will this change build times? Will any new dependencies be introduced? * **Hardware:** Does this affect any specific architectures or boards? * **Documentation:** Is documentation necessary to explain how to use this new feature or any configuration options? * **Security:** Could this introduce any potential security vulnerabilities? * **Compatibility:** Will this break existing code or configurations? * **Testing:** * **"No" is not acceptable.** Every PR needs testing to ensure it works as expected and doesn't introduce regressions. * **Provide specific details:** * Which host operating system, compiler version, and build system did you use? * Which target architecture and board did you test on? * Include actual logs or output demonstrating the change's behavior before and after your modifications. **Example of an improved summary and testing section:** ``` ## Summary This PR enables the use of the compiler-rt library's builtin functions by adding the necessary configuration options and build system logic. This change is necessary to: * [Explain the problem being solved, e.g., "improve the performance of certain math operations", "fix incorrect behavior when using specific compiler optimizations"] * [Highlight the benefits, e.g., "reduce code size", "enhance compatibility with other libraries"] Specifically, this PR modifies the following: * `configs/board-name/defconfig`: Adds `CONFIG_LIBBUILTINS=y` * `Makefile`: Includes logic to link against `libcompiler_rt` when enabled ## Testing I confirm that the changes have been tested on the following setup: * **Build Host:** Ubuntu 20.04, GCC 10.2.0 * **Target:** QEMU Emulator (ARM Cortex-M4) **Testing logs before change:** ``` [Show relevant log output demonstrating the issue or lack of functionality] ``` **Testing logs after change:** ``` [Show log output demonstrating the issue is resolved or the new functionality is working] ``` ``` **Remember:** A well-written PR description saves reviewers time and increases the likelihood of your changes being accepted quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
