nuttxpr commented on PR #14534: URL: https://github.com/apache/nuttx/pull/14534#issuecomment-2442120974
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **Yes, the PR meets the basic NuttX requirements.** **However, it's missing some details to be considered complete:** * **Summary:** * **What functional part of the code is being changed?** Specify if it's related to a specific driver, library, or core NuttX functionality. * **How does the change exactly work?** Briefly explain the technical approach to fixing the print warnings (e.g., "Replaced printf with syslog," "Added type casting to arguments," etc.). * **Impact:** * **Impact on build:** Since it fixes build warnings, specify if the build process itself changes (e.g., new compiler flags required) or if it just removes warnings from the output. * **Testing:** * **Build Host(s):** Provide more information about your build host OS, CPU architecture, and compiler version. * **Testing logs:** While you mention "nucleo-f302r8", it's better to include actual snippets of the build logs (before and after the fix) to demonstrate the warnings being resolved. **In short, the PR structure is good, but adding more specifics will make it much stronger.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
