nuttxpr commented on PR #14541: URL: https://github.com/apache/nuttx/pull/14541#issuecomment-2443513361
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. **Yes, the PR appears to meet the NuttX requirements.** **Here's why:** * **Summary:** * Clearly states the change (adding esp32s3 reset reasons interface). * Specifies the functional part of the code being changed (xtensa/esp32s3). * Describes how the change works (provides a function to read reset reasons). * **Impact:** * Clearly outlines the impact is limited to esp32s3. * Addresses all other impact points, stating "NO" where applicable. * **Testing:** * Confirms testing on a local setup. * Specifies the target (esp32s3). * Describes the testing process (resetting using different methods and reading reset reasons). * **However**, it lacks concrete testing logs. Including actual "before" and "after" logs would further strengthen the PR. **Suggestion:** Add actual testing logs (even if brief) to the "Testing" section to showcase the change's effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
