nuttxpr commented on PR #2801: URL: https://github.com/apache/nuttx-apps/pull/2801#issuecomment-2445120827
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. ## NuttX PR Requirements Review While the provided information is a good start, it does not fully meet the NuttX PR requirements. Here's a breakdown: **Strengths:** * **Clear summary:** The summary clearly explains the purpose of the change (new demo application), its functionality (Bluetooth data display), and potential use cases (real and dummy data scenarios). * **Testing information:** You mentioned the target boards used for testing (ESP32-Sparrow, ESP32-devkitc) and provided context on a workaround implemented for advertising issues. **Areas for improvement:** * **Missing details in Summary:** * **Functional part:** Specify which part of the codebase is affected (e.g., `apps/examples/bluetooth`). * **How it works (technical details):** Briefly explain the implementation details, like which Bluetooth profiles are used, how data is transmitted/received. * **Issue/PR references:** Link any related issues or PRs (if applicable). * **Incomplete Impact assessment:** * **New feature:** Clearly state that this is a new demo application. * **User Impact:** Describe how users can utilize this new application (e.g., building and flashing instructions, commands to run). * **Build impact:** Mention any new dependencies or build configuration changes required. * **Documentation impact:** Confirm if documentation is updated/provided to reflect this new application. * **Other impacts:** Address all other impact points (hardware, security, compatibility) even if they are not applicable ("N/A" is acceptable). * **Missing Testing logs:** Provide actual testing logs (before and after the change) to demonstrate the application's functionality. **Recommendations:** 1. **Expand the Summary** section with the missing technical details and references. 2. **Thoroughly address all points** in the Impact section, even if the impact is "NO" or "N/A". 3. **Include actual testing logs** demonstrating the application's behavior before and after your changes. By providing this additional information, your PR will be more comprehensive and better aligned with NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
